fix password hint check #5189
Merged
fix password hint check #5189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don't show password hints if you have disabled the hints with PASSWORD_HINTS_ALLOWED=false or if you have not configured mail and opted into showing password hints
|
I'm ambivalent about this change, but if this will be the new behavior, then I think the descriptions in |
jjlin
approved these changes
Nov 12, 2024
|
Change looks good to me, I think we should we also mention in the docs that |
stefan0xC
force-pushed
the
fix-password-hint
branch
from
f0d46ab to
611a1c3
Compare
dani-garcia
approved these changes
Nov 12, 2024
|
Thanks! |
BlackDex
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as noticed by @jjlin #5179 (comment) this is currently not correct.
don't show password hints if you have disabled the hints with
PASSWORD_HINTS_ALLOWED=falseor if you have not configured mail and also not opted into showing password hints